Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Blur/Grain & Denoise in global mode #7274

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Lawrence37
Copy link
Collaborator

@Desmis I created this PR from your fixbug-blur branch to fix the blur not being applied to the entire image when global mode is selected. There are a lot more changes than I expected, so I'll need you to explain what they do. I need more context to understand the code.

Closes #7226.

@Desmis
Copy link
Collaborator

Desmis commented Dec 24, 2024

@Lawrence37

Hello Lawrence

I am very touched and surprised by your creation of this PR. This consideration of my work is an important point that I will take into account.
Today is Christmas, a time for festivities with the family, and I'll be taking a closer look at the answers to your questions and what to do next in a few days' time.

Thank you for your kind words.

I just sent you a personal message (PM) to clarify.

Jacques

@Lawrence37
Copy link
Collaborator Author

Marking this as a draft while I make the agreed changes. This PR will be used solely to fix the bug. The enhancements will be included in a separate PR.

@Lawrence37 Lawrence37 marked this pull request as ready for review January 19, 2025 23:48
@Lawrence37
Copy link
Collaborator Author

Ready for review 🙂
@Desmis I hope this is correct. I did some brief testing and it seems to work perfectly.

@Desmis
Copy link
Collaborator

Desmis commented Jan 20, 2025

@Lawrence37

It is OK for me :)

Jacques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur & Noise in Blur/Grain & Denoise not applied globally with the global spot method
2 participants